Profile change bug reversion in 3.5.7

[pdp8user]

Version 3.5.5 or 3.5.6 fixed a bug whereby a member attempting to update their profile received an error message saying that their email address is invalid. This was caused by the profile form having wrong information in some of its fields.

That bug has returned in 3.5.7

I looked into the Subversion repository to find the corrected code, but your repository skips versions 3.5.5 & 3.5.6 🙁

Any chance of a correction update?

[mbrsolution]

Hi, thank you for reporting this issue. The plugin developers will investigate further this issue/bug report.

Thank you

[admin]

Hi, The github repository for this plugin is here:
https://github.com/wp-insider/simple-membership

Which change or line of code are you referring to?

[pdp8user]

Thank you for that.

I’ve looked into the issue further, and it isn’t what I thought at first.
The problem seems to be browser dependent, and what I thought was a reversion is in fact a different behaviour between different browsers.

In particular, I can only get it to fail on Safari (on Mac & iOS – I don’t have access to Safari on Windows). It behaves correctly on a range of other browsers and platforms.

When I load the profile page on Safari (…/membership-login/membership-profile/), the page initially loads with the correct information in the pre-filled form fields. Then, at what looks like the “page loaded” time point, it overwrites the correct content of the email field with the member’s username and writes something also into the first of the password fields. That password field should in fact remain empty. (The actual content of the password field is, of course, not visible but it is the same length as the current password.)

Regards
Brian

[pdp8user]

I didn’t think to mention in my previous post: prior to about Aug 22 of this year (3.5.6?), this issue (or something very similar) was occurring on Firefox as well as Safari. At that stage my MacOS users could only update their profiles using Chrome. It was resolved with an update on Firefox at that time, which is why I thought it was a reversion when I saw it again today.

Please accept my apologies if that assumption caused you any problems.

Further, I’ve also verified that the issue occurs even after I’ve disabled all plugins except Simple Membership, reverted to the TwentySeventeen theme and completely cleared my browser cache.

Regards
Brian

[pdp8user]

I’ve tracked the cause of the issue.
It’s not a Simple Membership problem, it’s Safari.

Safari (v11.0) is not honouring the autocomplete="off" attribute of the form fields.
It doesn’t honour it if you put it on the entire form, either.

Not only that, for some twisted reason it fills the field that has id="email" with the value it has previously gathered from the swpm-login-form field swpm_user_name. (Maybe the assumption is that the field preceding the password one must be the user-id field?)

So, if you log in with your email address, the form gets the right value in the email field. If you log in with your username, it gets the wrong one. Furthermore, it always adds a value to the first password field, even though the user may not want to change the password on this occasion.

My apologies for causing any concern.

Brian

[mbrsolution]

Thank you very much Brian.

Your troubleshooting steps and finding out the issue will help others running a Mac operating system with Safari (v11.0). Well done :). I am also curious to know if this issue also applies to Safari for windows 10?

Kind regards

[Author]

Posts